Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Persona Bar does not use Resource files for "All Users" #6119

Open
2 tasks done
Timo-Breumelhof opened this issue Aug 29, 2024 · 1 comment
Open
2 tasks done

Comments

@Timo-Breumelhof
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

What happened?

I edited SharedResources.resx to fix #6091. This works for the Module permissions grid, but not the Persona Bar.

image

image

Steps to reproduce?

  1. Edit SharedResources.resx and change "All Users to "Everyone"
  2. Open the Permissions of Page in the Persona Bar
  3. It still says "All Users" in the permissions grid.

Current Behavior

Persona Bar has the virtual role "All Users" text hard coded

Expected Behavior

The text should be loaded from the resource file SharedResources.resx

Relevant log output

No response

Anything else?

Related to #6091 and both should be fixed at the same time IMO.
All users > Everyone change : https://dnncommunity.org/forums/future-development/dnn-ideas/quotall-usersquot-is-not-the-best-term-for-security/

Affected Versions

9.13.3 (latest release)

What browsers are you seeing the problem on?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Timo-Breumelhof Timo-Breumelhof changed the title [Bug]: Persona Bar does not user Resource files for "All Users" [Bug]: Persona Bar does not use Resource files for "All Users" Aug 29, 2024
@bdukes
Copy link
Contributor

bdukes commented Aug 29, 2024

The current permission grid calls Localization.LocalizeRole on the role name. If the Persona Bar's RoleController API methods are updated to call that before returning to the frontend, that should get us pretty close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants