Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to oci-import builder? #124

Open
tianon opened this issue Jan 22, 2025 · 1 comment
Open

Convert to oci-import builder? #124

tianon opened this issue Jan 22, 2025 · 1 comment

Comments

@tianon
Copy link
Member

tianon commented Jan 22, 2025

Now that DOI has a means of importing OCI images as-is, our non-Windows images are no longer getting much value out of being built from a Dockerfile, and we could convert that metadata directly into JSON instead.

See:

It's probably worthwhile to consider this together with #122 (because it'll be some amount of repository churn), and might actually be a good use case for the File: support in the oci-import builder that so far hasn't had any actual load-bearing uses yet.

It's probably also worth considering doing uncompressed tarballs, since our binaries are already minimal, but it's also possible we get reasonable compression, so it's something that could be considered (we simply shouldn't rule out doing uncompressed tarballs without actually evalutating it).

@tianon
Copy link
Member Author

tianon commented Jan 22, 2025

An alternative to consider would be doing the binary builds themselves in the Dockerfile directly (multi-stage), which would give us more interesting provenance.

Edit: something like:

FROM xxx AS build
COPY code ....
RUN compilation steps
FROM scratch AS test
COPY --from=build /hello /hello
RUN ["/hello"]
FROM scratch
COPY --from=test /hello /hello
CMD ["/hello"]

(perhaps we should track this as a separate competing issue)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant