diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 33479a2aa..b578f9d65 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -393,7 +393,7 @@ jobs: MYSECRET=foo INVALID_SECRET= - secret-env: + secret-envs: runs-on: ubuntu-latest steps: - diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml index 6715ccc1d..06dc9c385 100644 --- a/.github/workflows/e2e.yml +++ b/.github/workflows/e2e.yml @@ -88,13 +88,13 @@ jobs: username_secret: QUAY_USERNAME password_secret: QUAY_TOKEN type: remote - - - name: Artifactory - registry: sforzando-build-team-local.jfrog.io - slug: sforzando-build-team-local.jfrog.io/build-push-action-e2e - username_secret: ARTIFACTORY_USERNAME - password_secret: ARTIFACTORY_TOKEN - type: remote +# - +# name: Artifactory +# registry: sforzando-build-team-local.jfrog.io +# slug: sforzando-build-team-local.jfrog.io/build-push-action-e2e +# username_secret: ARTIFACTORY_USERNAME +# password_secret: ARTIFACTORY_TOKEN +# type: remote - name: Harbor id: harbor diff --git a/README.md b/README.md index 426e4058a..00a830cf6 100644 --- a/README.md +++ b/README.md @@ -238,7 +238,7 @@ Following inputs can be used as `step.with` keys | `push` | Bool | [Push](https://docs.docker.com/engine/reference/commandline/buildx_build/#push) is a shorthand for `--output=type=registry` (default `false`) | | `sbom` | Bool/String | Generate [SBOM](https://docs.docker.com/build/attestations/sbom/) attestation for the build (shorthand for `--attest=type=sbom`) | | `secrets` | List | List of [secrets](https://docs.docker.com/engine/reference/commandline/buildx_build/#secret) to expose to the build (e.g., `key=string`, `GIT_AUTH_TOKEN=mytoken`) | -| `secret-envs` | List/CSV | List of [secrets](https://docs.docker.com/engine/reference/commandline/buildx_build/#secret) to expose to the build using environment variables (e.g., MY_SECRET=MY_ENV_VAR) | +| `secret-envs` | List/CSV | List of [secret env vars](https://docs.docker.com/engine/reference/commandline/buildx_build/#secret) to expose to the build (e.g., `key=envname`, `MY_SECRET=MY_ENV_VAR`) | | `secret-files` | List | List of [secret files](https://docs.docker.com/engine/reference/commandline/buildx_build/#secret) to expose to the build (e.g., `key=filename`, `MY_SECRET=./secret.txt`) | | `shm-size` | String | Size of [`/dev/shm`](https://docs.docker.com/engine/reference/commandline/buildx_build/#shm-size) (e.g., `2g`) | | `ssh` | List | List of [SSH agent socket or keys](https://docs.docker.com/engine/reference/commandline/buildx_build/#ssh) to expose to the build | diff --git a/action.yml b/action.yml index 3cdf81f85..dc38d9ed6 100644 --- a/action.yml +++ b/action.yml @@ -81,7 +81,7 @@ inputs: description: "List of secrets to expose to the build (e.g., key=string, GIT_AUTH_TOKEN=mytoken)" required: false secret-envs: - description: "List of secrets to expose to the build using environment variables (e.g., MY_SECRET=MY_ENV_VAR)" + description: "List of secret env vars to expose to the build (e.g., key=envname, MY_SECRET=MY_ENV_VAR)" required: false secret-files: description: "List of secret files to expose to the build (e.g., key=filename, MY_SECRET=./secret.txt)"