Skip to content
This repository has been archived by the owner on Nov 23, 2019. It is now read-only.

Migrate docker/cliconfig to engine-api ? #106

Open
pdalpra opened this issue Feb 22, 2016 · 1 comment
Open

Migrate docker/cliconfig to engine-api ? #106

pdalpra opened this issue Feb 22, 2016 · 1 comment

Comments

@pdalpra
Copy link
Contributor

pdalpra commented Feb 22, 2016

Hi Docker developers :)

I just heard about this project, and having a officially supported Go binding to interact with Docker API is great.

However, like other Go bindings such as go-dockerclient that provide it, it would be very nice to be able to get a map[string]types.AuthConfig from ~/.docker/config.json/.dockercfg.
In docker/docker, this feature is provided by the cliconfig.

Would it be possible to migrate at least the reading part of cliconfig to engine-api ?

I'd be glad to provide a PR if you like.

@calavera
Copy link
Contributor

I really have mixed feelings about this. That structure is easy enough to build a parser yourself, but I understand that it could be convenient to have a canonical implementation.

FWIW, registry authentication will have some changes in 1.11 that we'd need to consider if we move this forward:

  1. External stores just landed in Client credentials store. moby/moby#20107
  2. Long lived tokens rather than user/password will probably land 🔜 Add support for getting token from login #108

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants