Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sidebar and navbar path configs need to take into account the routerMode #2133

Open
trusktr opened this issue Jul 16, 2023 · 0 comments
Open

Sidebar and navbar path configs need to take into account the routerMode #2133

trusktr opened this issue Jul 16, 2023 · 0 comments

Comments

@trusktr
Copy link
Member

trusktr commented Jul 16, 2023

PR #1970 adds more documentation on how routerMode currently affects sidebar and navbar loading.

Ideally, there should not be any difference, and the sidebar and navbars paths should be determined in the same way no matter the routerMode.

With hash router mode, it seems that the paths are determined from the base of the site, whereas with history router mode, the paths are determined based on the current page path.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@trusktr