Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect error message when app has no handlers. #101

Closed
jmalloc opened this issue Oct 13, 2020 · 5 comments
Closed

Incorrect error message when app has no handlers. #101

jmalloc opened this issue Oct 13, 2020 · 5 comments
Labels
bug Something isn't working
Milestone

Comments

@jmalloc
Copy link
Member

jmalloc commented Oct 13, 2020

✗ record a specific 'event.FriendRequestSent' event

  | EXPLANATION
  |     no relevant handler types were enabled
  | 
  | SUGGESTIONS
  | 

It's not that the handler type was disabled, there simply were none (aggregate, in this case).

@jmalloc
Copy link
Member Author

jmalloc commented Oct 13, 2020

This seems to occur when there are no handlers that consume the command type at all.

@jmalloc jmalloc added this to the 1.0.0-rc.0 milestone Oct 20, 2020
@jmalloc jmalloc added the bug Something isn't working label Oct 20, 2020
@jmalloc
Copy link
Member Author

jmalloc commented Oct 20, 2020

Might relate to #66

@jmalloc
Copy link
Member Author

jmalloc commented Oct 20, 2020

This also seems pretty close to #65, which may be out of date, or perhaps there are two subtly different problems here.

@jmalloc
Copy link
Member Author

jmalloc commented Oct 24, 2020

@danilvpetrov Do you remember how this was happening? I can't seem to reproduce it in tests.

I get a panic instead:

 Test Panicked
    the fixtures.MessageA message type is not consumed by any handlers

@jmalloc
Copy link
Member Author

jmalloc commented Oct 24, 2020

Ok, I was able to reproduce this with [email protected] and [email protected], which is what we were using when pair programming in the "friends" domain, the panic added in PR #49 prevents this behavior in current versions of testkit.

@jmalloc jmalloc closed this as completed Oct 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant