Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to limit checks to next applicable Cluster version. #444

Open
des1redState opened this issue Jan 31, 2023 · 4 comments
Open

Add flag to limit checks to next applicable Cluster version. #444

des1redState opened this issue Jan 31, 2023 · 4 comments
Assignees
Labels
Milestone

Comments

@des1redState
Copy link

Since Clusters can only be upgraded by one minor release at a time, I don't want to see deprecation warnings for versions which are irrelevant to my current upgrade task. For example, if I'm handling a 1.21 > 1.22 upgrade, I only want to see deprecations relevant to that particular upgrade, not all future upgrades. It'd also make automation easier, for example, -e currently returns a non-zero exit code even if the next applicable version has no relevant deprecations.

@des1redState des1redState changed the title Limit checks to only the next applicable Cluster version. Add flag to limit checks to only the next applicable Cluster version. Jan 31, 2023
@des1redState des1redState changed the title Add flag to limit checks to only the next applicable Cluster version. Add flag to limit checks to next applicable Cluster version. Jan 31, 2023
Copy link
Collaborator

I like this idea.

@stepanstipl
Copy link
Contributor

Thanks for the suggestion @des1redState - we already do this and if we can detect cluster version, we filter out results that aren't relevant1. If that is not working as expected, please share details.

But I assume the ask is however not to filter non-relevant results, in a sense to keep only API upgrades that can be made, but rather to filter out all non-required upgrades, i.e. only keep the ones that have to be resolved before upgrade to the next version, correct?

Footnotes

  1. https://github.com/doitintl/kube-no-trouble/blob/34bff74c89c21f749d2ab38d5c384590ea53d2b6/pkg/printer/filter.go#L7-L21

@des1redState
Copy link
Author

des1redState commented Jan 31, 2023

@stepanstipl Well, to be clear, what I'm asking of the tool boils down to:

"You know I'm currently on v1.21, ONLY tell me about deprecations in v1.22"

That doesn't seem to be the case, as currently I'm also presented with deprecations related to v1.25

@stepanstipl stepanstipl added the feature New feature or request label Jan 31, 2023
@stepanstipl stepanstipl added this to the 0.8.0 milestone Jan 31, 2023
@stepanstipl
Copy link
Contributor

Ok, thanks for the clarification. Sounds like a useful feature, and should be fairly easy to implement. I would still keep this under a flag, i.e. non-default behaviour, but 👍 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants