Return code when the cluster is not accessible or if is there an issue with authentication

[xzizka]

Hello,

During our tests we found, that kubent returns return code = 0 both when the cluster does not exist.

xzizka@xzizka:~$ kubent -e 
12:39PM INF >>> Kube No Trouble `kubent` <<<
12:39PM INF version 0.7.0 (git sha d1bb4e5fd6550b533b2013671aa8419d923ee042)
12:39PM INF Initializing collectors and retrieving data
12:40PM INF Retrieved 0 resources from collector name=Cluster
12:40PM ERR Failed to retrieve data from collector error="list: failed to list: Get \"https://127.0.0.1:34748/api/v1/secrets?labelSelector=owner%3Dhelm\": dial tcp 127.0.0.1:34748: connect: connection refused" name="Helm v3"
12:40PM INF Loaded ruleset name=custom.rego.tmpl
12:40PM INF Loaded ruleset name=deprecated-1-16.rego
12:40PM INF Loaded ruleset name=deprecated-1-22.rego
12:40PM INF Loaded ruleset name=deprecated-1-25.rego
12:40PM INF Loaded ruleset name=deprecated-1-26.rego
12:40PM INF Loaded ruleset name=deprecated-future.rego
xzizka@xzizka:~$ echo $?
0

and when there is an issue with authentication.

xzizka@xzizka:~$ kubent -e 
12:40PM INF >>> Kube No Trouble `kubent` <<<
12:40PM INF version 0.7.0 (git sha d1bb4e5fd6550b533b2013671aa8419d923ee042)
12:40PM INF Initializing collectors and retrieving data
12:40PM ERR Failed to initialize collector: <nil> error="failed to assemble client config: error loading config file \"/home/xzizka/.kube/config\": illegal base64 data at input byte 1532"
12:40PM ERR Failed to initialize collector: <nil> error="failed to assemble client config: error loading config file \"/home/xzizka/.kube/config\": illegal base64 data at input byte 1532"
12:40PM INF Loaded ruleset name=custom.rego.tmpl
12:40PM INF Loaded ruleset name=deprecated-1-16.rego
12:40PM INF Loaded ruleset name=deprecated-1-22.rego
12:40PM INF Loaded ruleset name=deprecated-1-25.rego
12:40PM INF Loaded ruleset name=deprecated-1-26.rego
12:40PM INF Loaded ruleset name=deprecated-future.rego
xzizka@xzizka:~$ echo $?
0

There is an error message returned about the issue, but I would not expect returning of return code = 0 when kubent was not able to connect successfully to the cluster.
The definition of the -e parameter is:

-e, --exit-error                      exit with non-zero code when issues are found

I would consider the unsuccessful connection to the cluster as an issue.
Do you agree with this position?

Thank you
Ondrej

[stepanstipl]

Hi @xzizka, this is definitely not desirable and we should look into fixing this. Thanks for reporting this 👍 .

[github-actions]

This issue has not seen any activity in last 60 days, and has been marked as stale.

[stepanstipl]

I believe only 1/2 of this is fixed, see #527 for details.

[dark0dave]

#527 (review)

Still a few tests to add here.