Is BroadcastSystemMessage necessary ?

[uhonermann]

Hello,

the call to BroadcastSystemMessage after mounting the drive takes between 5 and 30 seconds on some systems.
So I wonder if it is really necessary to call it.

Regards,
Uwe

[Liryna]

The mount is already broadcast by the library on mount and unmount.

dokany/dokan/mount.c

Line 508 in 036fc02

VOID DokanBroadcastLink(WCHAR cLetter, BOOL bRemoved) {

Maybe a third app is delaying its effect ?

Could it be due to #528 ?

[uhonermann]

Hi Liryna,

it's exactly the call to BroadcastSystemMessage from DokanBroadcastLink, that is taking such a large amount of time (on some, but unfortunately many, machines).
I think, it is because of some applications that delay it, but it seems to be hard to find these applications (already tried using Spy++).

So I was wondering what is going to happen if I simply remove the BroadcastSystemMessage call.

Regards,
Uwe

[Liryna]

If we don't call BroadcastSystemMessage, explorer or other app are not going to reflect the mount / unmount in their UI or else.

It is sadly "expected" that BroadcastSystemMessage hangs due to external apps. What we should do here is starting a thread and execute this call separately to the mount thread.

[uhonermann]

Hm, yes, you're absolutely right, that would be the perfect solution.

[uhonermann]

I just tried it completely without the BroadcastSystemMessage, and couldn't find any problem so far.
The mount is extremely fast now (less than a second).

Okay, we mount a network drive for current session, maybe it makes a difference if mounting a local disk device globally.
But we use local disk device only for server systems, where the speed of mounting doesn't really matter.

[Liryna]

I have created #1187 to track the change. Thanks!

[Liryna]

This is done with d715188

[uhonermann]

Hi Liryna,

our customer confirms, that the delay does not happen anymore with that version.

Regards,
Uwe

[Liryna]

Thanks for the confirmation!