Please revert commit 81eca07b348e55d391f357c137adaa8fd8f11dc0, it breaks cross compiled dokan fuse builds.

[Daniel-Abrecht]

The commit 81eca07 changes all occurrences of #include <windows.h> to #include <Windows.h>, claiming it to correct a typo. Windows is case insensitive, and the capitalization of windows.h varies greatly across different windows SDKs, so this change neither fixes nor improves anything on windows.

Because linux is case sensitive and all linux cross compilers use lowercase for windows.h, the change broke cross compiling of dokan fuse and of applications which use dokan fuse.

Please revert commit 81eca07.

[Rondom]

I and commit 0e8366c agree :-D

[kyanha]

Does dokan_fuse/include/fuse_win.h need the same treatment?

[Daniel-Abrecht]

All of the following files need the fix:

dokan_fuse/src/dokanfuse.cpp
dokan/dokan.h
dokan/dokani.h
dokan/list.h
dokan_fuse/src/fusemain.cpp
dokan_fuse/src/utils.cpp
dokan_fuse/src/fuse_helpers.c

dokan_fuse/include/fuse_win.h is not affected, because the include in there is only included if _MSC_VER is defined.

Commit 0e8366c only fixes dokan/dokan.h, which isn't sufficient. I've attached some build logs to show that every file I listed above indeed needs the fix: log.txt

Edit: I just noticed commit 0e8366c was from 2016 anyway.

[Rondom]

Edit: I just noticed commit 0e8366c was from 2016 anyway.

That was just a tongue-in-cheek way of saying that I fixed this before ;-)

[Liryna]

My bad 😞 made the change after trying to fix some sonarqube report and missed this point.
Thank you for the report @Daniel-Abrecht !

[kyanha]

Hey @Liryna, is there a public SonarQube instance or SonarCloud for the dokan-dev projects? I'm pretty sure that SonarCloud is free for open source projects.

[Liryna]

Hey @kyanha , Sonar allows opensource to use it for free. You can find the link in the readme: https://sonarcloud.io/dashboard?id=dokany

[kyanha]

Cool, thanks! Do you have any plans to load the dokan-dotnet, dokan-sshfs, dokan-delphi, dokan-java, and/or dokan-ruby projects into it?

[Liryna]

I have created a ticket to keep in mind for dokan-dotnet dokan-dev/dokan-dotnet#191
For other projects, have to see with other maintainers if they plan to do it (also probably add a CI like appveyor at first 😃 )