Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Test Coverage For to as object & function #30

Open
majew7 opened this issue Jul 15, 2020 · 0 comments
Open

Improve Test Coverage For to as object & function #30

majew7 opened this issue Jul 15, 2020 · 0 comments

Comments

@majew7
Copy link
Contributor

majew7 commented Jul 15, 2020

Requested Update

Enhance test.js - describe('react-passage', () => {})

Provide consistent coverage for:

  • to string
  • to as location object - and pathname, search, hash, state
  • to as function and pathname, search, hash, state

Why Is This Update Needed?

The to property of React Passage's Link accepts a string, object or function which is higher complexity than just working with a url string.

Currently test.js tests are light, and do an incomplete job ensuring that Passage's Link are working correctly by retain all the relevant values pathname, search, hash, state.

Are There Examples?

One example of light coverage:
it('matches with a function that returns a location object', () => {})
The incompleteness is missing coverage to ensure state is passed through.

@majew7 majew7 changed the title Tests Missing - Tests Missing For to as object & to as function Jul 15, 2020
@majew7 majew7 changed the title Tests Missing For to as object & to as function Tests Missing For to as object & function Jul 15, 2020
@majew7 majew7 changed the title Tests Missing For to as object & function Improve Test Coverage For to as object & function Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant