We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hi dolmen, Thanks for creating a great utility to make Git interaction with Github secure! When I specified the comment (via -C argument) for my key on the comment line, it was not passed through to the underline ssh-keygen command. I digged into the code and found that the key comment is hard-coded at https://github.com/dolmen/github-keygen/blob/release/github-keygen#L9447 My workaround is to specify my comment string at https://github.com/dolmen/github-keygen/blob/release/github-keygen#L9452 :) I don't know about Perl so I cannot do a proper fix. :(.
The text was updated successfully, but these errors were encountered:
Thanks for the report!
Confirmed.
Here is how to reproduce:
$ mkdir tmp; HOME=$PWD/tmp perl -I../lib ../bin/github-keygen toto -C toto && cat tmp/.ssh/[email protected] ; rm -Rf tmp
Sorry, something went wrong.
Fix ignored -C when creating key (GitHub #46)
ca47bda
When a user was providing a custom key comment via -C, it was ignored and our default comment always overrided it. Fixed. #46
README: changelog for #46 fix
3b15af9
No branches or pull requests
Hi dolmen,
Thanks for creating a great utility to make Git interaction with Github secure!
When I specified the comment (via -C argument) for my key on the comment line, it was not passed through to the underline ssh-keygen command.
I digged into the code and found that the key comment is hard-coded at https://github.com/dolmen/github-keygen/blob/release/github-keygen#L9447
My workaround is to specify my comment string at https://github.com/dolmen/github-keygen/blob/release/github-keygen#L9452 :)
I don't know about Perl so I cannot do a proper fix. :(.
The text was updated successfully, but these errors were encountered: