Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functional Dependency anaylsis on simple nested joins doesn't behave as expected. #1895

Open
nicktobey opened this issue Jul 24, 2023 · 0 comments

Comments

@nicktobey
Copy link
Contributor

Put a breakpoint in lookupJoinSelectivity before the call to sql.NewLookupFDs

Run the following SQL:

drop table if exists one_pk;
create table one_pk (pk smallint primary key);

insert into one_pk values
    (0),
    (1),
    (2),
    (3);

SELECT a.* FROM one_pk a JOIN one_pk c JOIN one_pk b ON b.pk = c.pk and b.pk = a.pk;

As part of costing joins, we attempt to detect lookups that we know will always return at most one row. The joins here can be reordered, but regardless of the ordering, this is a perfect candidate of such a lookup: each table is a single column, which is a unique primary key. A lookup into such a table always has at most one result. So we expect that fds.HasMax1Row() within lookupJoinSelectivity should return true. But it returns false instead, and we fail to prioritize this execution plan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant