Pattern for mapping json or yaml document incorrect

[dnperfors]

With the basic configuration it is possible to request swagger documents with incorrect extensions. I believe the following tests will fail (I haven't had the change to test this yet on the swashbuckle codebase):

        [Theory]
        [InlineData(typeof(Basic.Startup), "/swagger/v1/swagger.jsonxxx")]
        [InlineData(typeof(Basic.Startup), "/swagger/v1/swagger.yamlxxx")]
        [InlineData(typeof(Basic.Startup), "/swagger/v1/swagger.txt")]
        public async Task SwaggerEndpoint_ReturnsValidSwaggerJson(
            Type startupType,
            string swaggerRequestUri)
        {
            var testSite = new TestSite(startupType);
            var client = testSite.BuildClient();

            var swaggerResponse = await client.GetAsync(swaggerRequestUri);

            Assert.Equal(HttpStatusCode.NotFound, swaggerResponse.StatusCode);
        }

Instead of returning 404 NotFound these will return the json document.

The reason for this seems to be that the patter "/swagger/{documentName}/swagger.{json|yaml}" doesn't actually perform an "or" on the extension, but will generate a route parameter with the name "json|yaml" for the above example the value for this parameter is either "jsonxxx", "yamlxxx" or "txt"

[github-actions]

This issue is stale because it has been open for 60 days with no activity. It will be automatically closed in 14 days if no further updates are made.

[dnperfors]

This is still an issue, so please leave it open 😇

But I see a pr that should fix this issue 😇

[martincostello]

This should be fixed by #2418.