From 710fa0dfcb7876a55a1fa35ac84d7d3db402c7b8 Mon Sep 17 00:00:00 2001 From: Secretions Date: Tue, 19 Nov 2024 13:45:24 -0800 Subject: [PATCH] Revert "PLAT-8781: Give importer access to flytepropeller (#276)" (#299) This reverts commit d020b431f482cbf618a796791d7420a3187a1711. --- modules/flyte/README.md | 2 +- modules/flyte/iam.tf | 1 - modules/flyte/variables.tf | 1 - 3 files changed, 1 insertion(+), 3 deletions(-) diff --git a/modules/flyte/README.md b/modules/flyte/README.md index ed61a2c5..f411c348 100644 --- a/modules/flyte/README.md +++ b/modules/flyte/README.md @@ -53,7 +53,7 @@ No modules. | [kms\_info](#input\_kms\_info) | key\_id = KMS key id.
key\_arn = KMS key arn.
enabled = KMS key is enabled |
object({
key_id = string
key_arn = string
enabled = bool
})
| n/a | yes | | [platform\_namespace](#input\_platform\_namespace) | Name of Domino platform namespace for this deploy | `string` | n/a | yes | | [region](#input\_region) | AWS region for the deployment | `string` | n/a | yes | -| [serviceaccount\_names](#input\_serviceaccount\_names) | Service account names for Flyte |
object({
datacatalog = optional(string, "datacatalog")
flyteadmin = optional(string, "flyteadmin")
flytepropeller = optional(string, "flytepropeller")
importer = optional(string, "domino-data-importer")
})
| `{}` | no | +| [serviceaccount\_names](#input\_serviceaccount\_names) | Service account names for Flyte |
object({
datacatalog = optional(string, "datacatalog")
flyteadmin = optional(string, "flyteadmin")
flytepropeller = optional(string, "flytepropeller")
})
| `{}` | no | ## Outputs diff --git a/modules/flyte/iam.tf b/modules/flyte/iam.tf index ba77c66b..8f11f26c 100644 --- a/modules/flyte/iam.tf +++ b/modules/flyte/iam.tf @@ -15,7 +15,6 @@ resource "aws_iam_role" "flyte_controlplane" { "${trimprefix(local.oidc_provider_url, "https://")}:sub" : [ "system:serviceaccount:${var.platform_namespace}:${var.serviceaccount_names.datacatalog}", "system:serviceaccount:${var.platform_namespace}:${var.serviceaccount_names.flytepropeller}", - "system:serviceaccount:${var.platform_namespace}:${var.serviceaccount_names.importer}", ] } } diff --git a/modules/flyte/variables.tf b/modules/flyte/variables.tf index 645156c7..9536a831 100644 --- a/modules/flyte/variables.tf +++ b/modules/flyte/variables.tf @@ -54,7 +54,6 @@ variable "serviceaccount_names" { datacatalog = optional(string, "datacatalog") flyteadmin = optional(string, "flyteadmin") flytepropeller = optional(string, "flytepropeller") - importer = optional(string, "domino-data-importer") }) default = {}