Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signature changed for domo.streams.create #5

Open
simllll opened this issue Sep 6, 2017 · 1 comment
Open

signature changed for domo.streams.create #5

simllll opened this issue Sep 6, 2017 · 1 comment
Labels

Comments

@simllll
Copy link

simllll commented Sep 6, 2017

Hello all,
thanks for the great library.
I've notived since v2.0 the signature for domo.streams.create has change from:
domo.streams.create(dataset, updatemethod)
to one parameter:
domo.streams.create({dataSet: dataset, updateMethod: 'REPLACE'})

just a heads up if anyone else runs into this.

regards
Simon

@walexnelson
Copy link
Contributor

walexnelson commented Sep 7, 2017

Thanks @simllll, this was one of a few breaking changes to v2. It was done as part of the move to Typescript.

https://github.com/domoinc/domo-node-sdk/blob/master/src/streams/models.ts#L3

We tried to make sure the examples were updated accordingly. Hopefully, they helped and these breaking changes didn't cause you too much inconvenience.

https://github.com/domoinc/domo-node-sdk/blob/master/examples/Stream/create-stream.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants