Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] builds will likely break on RN 0.75 / Expo 52 #2812

Open
jamsch opened this issue Aug 3, 2024 · 2 comments
Open

[Android] builds will likely break on RN 0.75 / Expo 52 #2812

jamsch opened this issue Aug 3, 2024 · 2 comments

Comments

@jamsch
Copy link

jamsch commented Aug 3, 2024

Hi,

Just letting the maintainers of this library know that the enableJetifier option will be removed from upstream React Native / Expo:

facebook/react-native@14ccf6b
expo/expo@3774717#diff-c1abe9eea32a8e683dbea2f18a322cc0b8c5a4ce1a8da1719c6a9ddf29f79e3fL28

Because the enableJetifier option is removed, the following lines:

if (supportLibVersion && androidXVersion == null) {
implementation "com.android.support:support-annotations:$supportLibVersion"
implementation "com.android.support:customtabs:$supportLibVersion"
} else {

Resolves in a bare Expo SDK 51 app as the following:

+--- project :react-native-iap
|    +--- com.android.support:support-annotations:28.0.0
|    +--- com.android.support:customtabs:28.0.0

Which results in the following error:

> Task :app:processDebugMainManifest FAILED
/home/expo/workingdir/build/android/app/src/debug/AndroidManifest.xml:28:18-86 Error:
   Attribute application@appComponentFactory value=(androidx.core.app.CoreComponentFactory) from [androidx.core:core:1.12.0] AndroidManifest.xml:28:18-86
   is also present at [com.android.support:support-compat:28.0.0] AndroidManifest.xml:22:18-91 value=(android.support.v4.app.CoreComponentFactory).
   Suggestion: add 'tools:replace="android:appComponentFactory"' to <application> element at AndroidManifest.xml:6:5-162 to override.

For context, earlier this week I had run in to this issue after Expo deployed an update to their bare native template that included the removal of enableJetifier, but it was later reverted because of the above build issue mentioned here: expo/expo#30725

@leaguefun
Copy link

@jamsch FYI, I tried to remove the line "supportLibVersion" in android/build.gradle, that can fix the build broken

@sburgpit
Copy link

sburgpit commented Sep 3, 2024

@leaguefun I ran into the same problem on RN 0.75.2 and removing the supportLibVersion really fixed the build. However, it seems to be something important, can we just get rid of it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants