Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gen 1 incorrectly assumes 100% crit probability on Slash #199

Open
mpique opened this issue Mar 28, 2024 · 1 comment
Open

Gen 1 incorrectly assumes 100% crit probability on Slash #199

mpique opened this issue Mar 28, 2024 · 1 comment
Assignees
Labels
bug Something isn't working reviewed This has been looked at

Comments

@mpique
Copy link

mpique commented Mar 28, 2024

Captura

Captura4

Captura2

In Gen 1, the critical hit probability is calculated as T/255. For a High critical-hit ratio move T is:
Captura3

Since Parasect's base speed is 30, T = 120. That means it's only a 47,06% chance. Any Pokémon whose speed is equal or lower than 65 won't have a guaranteed crit.

I know, I'm pointing at an extremely small inconsistency that affetcts an extremely low number of Pokémon (15) in an extremely niche meta. But I think it's nice that the calc works properly in these situations anyway.

@analogcam
Copy link

this is a bug with the damage calc itself, so there's not much we can do, since they automatically apply the crit damage on their end.

@doshidak doshidak self-assigned this Jul 30, 2024
@doshidak doshidak added reviewed This has been looked at bug Something isn't working labels Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working reviewed This has been looked at
Projects
None yet
Development

No branches or pull requests

3 participants