Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shadow shield and multiscale show the wrong calculations for multi hit moves #66

Open
hkr061 opened this issue Nov 4, 2022 · 3 comments
Assignees
Labels
bug Something isn't working dank Good issue or request reviewed This has been looked at

Comments

@hkr061
Copy link

hkr061 commented Nov 4, 2022

Browser: Chrome
Showdex version: v1.0.5
When using a multi hit move against shadow shield or multiscale pokemon, the calculations assume the damage reduction applies to all hits, instead of just the first.

@doshidak
Copy link
Owner

doshidak commented Nov 5, 2022

Hey there!

This is a known issue, first discovered with Knock Off, where the calc would report 2HKO (for instance), but would become 2-3HKO once the opposing Pokémon's item is knocked off (as opposed to the expected 1HKO). Similar principle applies for multi-hit moves, as each consecutive hit needs to be recalculated with updated conditions (no item in the case of Knock Off and broken Shadow Shield/Multiscale in your case [broken as in no longer having an effect]).

Currently a low-priority fix as we use the O.G Damage Calculator under-the-hood (just the damage calculation part, not the UI). Would prefer those maintaining the O.G Damage Calculator to directly address this, but I can definitely fix this on Showdex's end if the maintainers don't end up pushing a fix in the near future.

I'll keep your issue open until either it's fixed in the O.G Damage Calculator or I fix this myself.

Thanks!

@doshidak doshidak self-assigned this Nov 5, 2022
@doshidak doshidak added bug Something isn't working reviewed This has been looked at dank Good issue or request labels Nov 5, 2022
@doshidak
Copy link
Owner

doshidak commented Nov 5, 2022

Also, totally forgot to ask, but as a little token of appreciation for taking the time to submit this bug report, I'd like to credit you by your Smogon Forums username (if you have one)! Otherwise, I can just link your GitHub.

(...Or if you don't want to be credited, no need to reply.)

@hkr061
Copy link
Author

hkr061 commented Nov 5, 2022

No worries! My forum username is Henkedew. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dank Good issue or request reviewed This has been looked at
Projects
Status: todo
Development

No branches or pull requests

2 participants