Check it out button in editing a WYSIWYG field has broken styles
#27341
Labels
Gardening Day
Merged
OKR : User Experience
Owned by Jason
QA : Approved
QA : Passed Internal
Release : 24.10.08
Bug Fixing
Team : Scout
Type : Defect
Comments
zJaaal
added
Type : Defect
Priority : 4 Low
OKR : User Experience
valentinogiardino
added a commit
that referenced
this issue
Oct 4, 2024
|
close in favor of #30248 |
3 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Oct 4, 2024
…#27341 (#30250) ### Proposed Changes * Updated the `dot-convert-to-block-info.component.html` template to use the `label` property of PrimeNG `pButton` instead of manually setting the button label inside the button element. * Imported the `ButtonModule` from PrimeNG in the `dot-convert-to-block-info.component.spec.ts` to properly support the `pButton` directive and its `label` property in tests. ### Checklist - [x] Tests - [x] Translations - [x] Security Implications Contemplated. ### Additional Info This update ensures that the `pButton` directive from PrimeNG correctly handles the button label by using the `label` property, allowing for more maintainable and PrimeNG-compliant code. Previously, the button label was manually rendered inside the button, which lead to styling issues. ### Screenshots Original | Updated :-------------------------:|:-------------------------: <img width="1383" alt="image" src="https://github.com/user-attachments/assets/6e9de521-6826-4a12-845d-08cc22a34764"> | <img width="1124" alt="image" src="https://github.com/user-attachments/assets/134bab72-ba5c-49e9-a60f-d4a9b2f3f5f3">
3 tasks
|
Fixed, Unable to reproduce after this fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Parent Issue
No response
Problem Statement
The styles for the
Check it outbutton on the Block Editor information for WYSIWYG are off, The label has an incorrect color.This just happens when editing a WYSIWYG field, when we create a new one the label has the correct color.
Steps to Reproduce
Screen.Recording.2024-01-16.at.4.45.16.PM.mov
Acceptance Criteria
As an user I want to see the label with the correct color and the correct contrast.
dotCMS Version
master-latestProposed Objective
User Experience
Proposed Priority
Priority 4 - Trivial
External Links... Slack Conversations, Support Tickets, Figma Designs, etc.
No response
Assumptions & Initiation Needs
No response
Quality Assurance Notes & Workarounds
No response
Sub-Tasks & Estimates
No response
The text was updated successfully, but these errors were encountered: