Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Xamarin.Android.Build.Tasks] Replace Newtonsoft.Json usage with System.Text.Json #9229

Open
pjcollins opened this issue Aug 20, 2024 · 0 comments
Open

[Xamarin.Android.Build.Tasks] Replace Newtonsoft.Json usage with System.Text.Json #9229

pjcollins opened this issue Aug 20, 2024 · 0 comments
Assignees
@dellis1972 @jonathanpeppers
Labels
Area: xamarin-android Build Issues building the xamarin-android repo *itself*. enhancement Proposed change to current functionality.
Milestone
.NET 10

Comments

@pjcollins
Copy link
Member

pjcollins commented Aug 20, 2024 •
edited
Loading

Context: #9226 (review)

We should be able to stop repacking or redistributing Newtonsoft.Json if we update the tasks which use it to instead use System.Text.Json. At a glance it looks like only the following tasks would need updating:

https://github.com/dotnet/android/blob/main/src/Xamarin.Android.Build.Tasks/Tasks/BuildAppBundle.cs
https://github.com/dotnet/android/blob/main/src/Xamarin.Android.Build.Tasks/Tasks/JavaDependencyVerification.cs
https://github.com/dotnet/android/blob/main/src/Xamarin.Android.Build.Tasks/Utilities/MamJsonParser.cs
@pjcollins pjcollins added the Area: xamarin-android Build Issues building the xamarin-android repo *itself*. label Aug 20, 2024
@dotnet-policy-service dotnet-policy-service bot added the needs-triage Issues that need to be assigned. label Aug 20, 2024
@pjcollins pjcollins removed the needs-triage Issues that need to be assigned. label Aug 20, 2024
@pjcollins pjcollins added this to the .NET 10 milestone Aug 20, 2024
@jpobst jpobst added the enhancement Proposed change to current functionality. label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dellis1972 dellis1972

@jonathanpeppers jonathanpeppers

Labels
Area: xamarin-android Build Issues building the xamarin-android repo *itself*. enhancement Proposed change to current functionality.
Projects
None yet
Milestone
.NET 10
Development

No branches or pull requests
4 participants
@jpobst @dellis1972 @jonathanpeppers @pjcollins