Customize icon based on server type

[kvenkatrajan]

Please refer to suggestion here :

#1684 (comment)

[adamint]

Since we have the server icon now, will this be a long-lived issue that we can refer to?

[kvenkatrajan]

Yes thats correct :) This one is tracking any future icon updates (DB etc.)

[JamesNK]

@adamint I just did this and then noticed it has an issue. Reassigned to myself.

[JamesNK]

Peer icon is customized. Can still customize server icon.

[mitchdenny]

Moving this to preview 4 since it is going to be a long lived issue?

[JamesNK]

I don't think we have any situations right now in our sample projects where the server/consumer is not HTTP. That will change when the .NET rabbitmq library supports OTEL. Just merged but not yet available: rabbitmq/rabbitmq-dotnet-client#1261

Look at this again when a package with this change is available: rabbitmq/rabbitmq-dotnet-client#1261

[davidfowl]

@JamesNK You can run eShop, the rabbitmq event bus is instrumented.

[JamesNK]

Unfortunately it's not instrumented well.

https://github.com/dotnet/eShop/blob/3b49f61a888656b038b5f044b0d4c5096fc9f073/src/EventBusRabbitMQ/RabbitMQEventBus.cs#L154 - this should be a consumer activity. And many standardized tags for rabbitmq are missing.

Do you want me to create an issue for someone to improve it, or leave it as-is and remove when new rabbitmq with built in OTEL support is used?

[davidfowl]

Do you want me to create an issue for someone to improve it, or leave it as-is and remove when new rabbitmq with built in OTEL support is used?

Yes to both things.

[JamesNK]

dotnet/eShop#168