-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WebToolsE2E][Aspire] There are some garbled characters in the Aspire dashboard Console log after installing SDK 9.0 RC2 #5716
Comments
Does this happen on every project and only at the beginning? |
@davidfowl This issue happens on every project every time |
@JamesNK can you look at this? |
I searched for some of the garbled characters and they match up with some ANSI escape sequences https://gist.github.com/fnky/458719343aabd01cfb17a3a4f7296797#common-private-modes
Hmm, is .NET 9 doing some funky stuff when the console starts up now? Introduced in RC2? |
cc @stephentoub ? |
Not to my knowledge. And I don't see any meaningful changes in System.Console in the last several months. Plus if this is actually Windows as cited, System.Console on Windows doesn't emit ANSI escape sequences; it uses the Win32 APIs for interactions. It only uses ANSI escape sequences on Unix. |
Maybe the new output is added in the Microsoft.Extensions.Logging layer? Regardless of where the output is added from, the Aspire console UI shouldn't print them. If there is an unknown/unsupport sequence then it should be ignored. And to avoid blank lines, perhaps ignore adding the line of output if it is 100% unsupported control characters. |
Some of the strings didn't look like the ANSI codes as I know them. I searched more to see if I could find them and got: https://conemu.github.io/en/AnsiEscapeCodes.html#ConEmu_specific_OSC
|
I think the console output is coming from here: How could msbuild logging leak into the app's console output? |
Are y'all invoking the |
Yes! |
@JamesNK Verify this bug shows blank lines after installing the latest SDK 9.0.100-rc.2.24474.11 + Aspire 9.0.0-preview.4.24474.5 in today's validation. Do we expect blank lines not to be displayed? |
Yes, that is expected. My fix removed the bad characters, but adding a new line isn't considered bad. The complete fix is inside .NET SDK. Try out the version suggested in this comment (or later). |
I don't think so. It's not a high impact bug. And it should be fixed in the SDK to remove the root cause before 9 ships. |
@JamesNK The msbuild issue 10579 has been fixed. But this issue is still reproducible with SDK 9.0 RC2 + Aspire 8.2.1 / Aspire 9.0 rc1 (fixed the garbled characters but left lines with the time but no content in the console). Is this a different issue? What can we do to fix this at its root? Open an another bug in the dotnet/msbuild repo? |
Looks like dotnet/msbuild#10579 isn’t completely fixed according to comments on it. Blank lines are coming from the sdk, not Aspire. We can only wait until it is fixed there. |
From what I‘ve read, the issue 10579 is now only reproes with Win server 2012 which doesn't support VT100. Not sure if there will be a deeper fix for that and the issue has also been closed. |
REGRESSION INFO:
Work in SDK 8.0.401 + Aspire 8.2.0
Work in SDK 9.0 RC1 + Aspire 9.0 P4
INSTALL STEPS
Clean machine: Win11 x64 23h2 ENU
Install SDK 9.0.100-rc.2.24463.45
Install Aspire 9.0.0-preview.4.24463.11
REPRO STEPS
dotnet run
Note:
ACTUAL
There are some garbled characters in the console log
EXPECTED
There is no garbled code in the console log
The text was updated successfully, but these errors were encountered: