Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qdrant client doesn't have HealthChecks #5768

Closed
Alirexaa opened this issue Sep 18, 2024 · 0 comments · Fixed by #6057
Closed

Qdrant client doesn't have HealthChecks #5768

Alirexaa opened this issue Sep 18, 2024 · 0 comments · Fixed by #6057
Labels
area-integrations Issues pertaining to Aspire Integrations packages untriaged New issue has not been triaged

Comments

@Alirexaa
Copy link
Contributor

Aspire.Qdrant.Client component doesn't have HealthChecks.

In #5767 PR we provide a HealthCheckRegistration with implementing QdrantHealthCheck.

The implementation is based on https://qdrant.tech/documentation/guides/monitoring/#kubernetes-health-endpoints.

Once #5767 is merged, we could support health check in Aspire.Qdrant.Client
@davidfowl davidfowl added area-integrations Issues pertaining to Aspire Integrations packages enhancement labels Sep 19, 2024
@Alirexaa Alirexaa mentioned this issue Sep 19, 2024
Closed
16 tasks
@Alirexaa Alirexaa mentioned this issue Oct 1, 2024
Merged
16 tasks
@joperezr joperezr added the untriaged New issue has not been triaged label Oct 15, 2024
eerhardt added a commit that referenced this issue Nov 6, 2024
@Alirexaa @eerhardt
Add health check support for Qdrant client (#6057)
ff671b1 
This PR Adds health check support for Aspire.Qdrant.Client.

We need to import Testcontainers for ConformanceTests.

Fix #5768

* Add health check support for Qdrant client

* Try to use qdrant-client health check

* Use Grpc connection string for Grpc client

* Apply suggestions from code review

---------

Co-authored-by: Eric Erhardt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-integrations Issues pertaining to Aspire Integrations packages untriaged New issue has not been triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add health check support for Qdrant client Alirexaa/aspire
3 participants
@davidfowl @joperezr @Alirexaa