Fix VerifyWithPgWeb failing test
#5787
Open
+8
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
community-contribution
davidfowl
reviewed
Sep 19, 2024
| var db = pg.AddDatabase(dbName); | ||
| pg.WithPgWeb(c => | ||
| { | ||
| c.WaitFor(db); |
There was a problem hiding this comment.
What creates the database? We have an issue today where the database health check won't get go healthy until the database exists. Since the apphost doesn't create the database, it means that it'll hang forever.
There was a problem hiding this comment.
In this test, we use postgres database which is the default database in the Postgres container and by default the postgres database exists.
Open
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5785
cc @davidfowl
Checklist
<remarks />and<code />elements on your triple slash comments?Microsoft Reviewers: Open in CodeFlow