Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Remove automatic _disableToc set condition #10021

Open
filzrev opened this issue Jun 18, 2024 · 0 comments
Open

[Feature Request] Remove automatic _disableToc set condition #10021

filzrev opened this issue Jun 18, 2024 · 0 comments
Labels
static-site Produce static HTML output ready for publishing to hosts like GitHub pages

Comments

@filzrev
Copy link
Contributor

filzrev commented Jun 18, 2024

Is your feature request related to a problem? Please describe.
On current docfx implementation.
docfx automatically disable TOC Area when (model._navPath === model._tocPath) condition met.

This behavior is not documented and it's confusing for user.
who using top-level toc.yml for both top-navigation and TOC.

This behavior can be changed by explicitly set disableToc:false or _layout: landing setting.
So I willing to remove this condition from template.

Describe the solution you'd like
Remove (model._navPath === model._tocPath) condition from following files.

Additional context
This change introduce BREAKING CHANGES for existing users.

@yufeih yufeih added the static-site Produce static HTML output ready for publishing to hosts like GitHub pages label Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
static-site Produce static HTML output ready for publishing to hosts like GitHub pages
Projects
None yet
Development

No branches or pull requests

2 participants