Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclear "catch (ApplicationException ex)" #6258

Closed
jinek opened this issue Jul 2, 2018 — with docs.microsoft.com · 2 comments
Closed

Unclear "catch (ApplicationException ex)" #6258

jinek opened this issue Jul 2, 2018 — with docs.microsoft.com · 2 comments
Labels
duplicate Indicates issues or PRs that are duplicate of existing ones [org][type][category]

Comments

Copy link

jinek commented Jul 2, 2018

Why was it put: "catch (ApplicationException ex)
{
writer.WriteLine("ApplicationException Message: {0}", ex.Message);
}
" and in case there is a reason, why rest of the code was not put in to this try/catch


Document Details

Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

@rpetrusha
Copy link
Contributor

Thanks for pointing this out, @jinek. This is probably a legacy code example that was written before the guidance that ApplicationException not be caught was issued. I'm especially thankful for your opening this issue, since it led me back to #4870, where I wrote that I'd provide you with guidance for getting started. I failed to do that, and I apologize. I'll add some comments to the original issue on what to do. If you'd still like to work on it, we'd really appreciate your help.
In the meantime, I'll close this issue, since the duplicated ApplicationException is covered by #4870.

@rpetrusha rpetrusha added the duplicate Indicates issues or PRs that are duplicate of existing ones [org][type][category] label Jul 2, 2018
@jinek
Copy link
Author

jinek commented Jul 2, 2018

Thanks! I'm still in. Don't apologize, take your time. May be it makes sense for you to start a discussion, probably others can take part of your work that you are going to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate Indicates issues or PRs that are duplicate of existing ones [org][type][category]
Projects
None yet
Development

No branches or pull requests

4 participants