Cancel FSI interactions via FCS net7?

[goswinr]

How to cancel FSI interactions in net7 ?
The new internal ControlledExecution.fs class seems to work well in VS for cancelling.
But I have not found a public member that exposes it to the FCS.
The cancelation token passed in via fsiSession.EvalInteraction(code,token) only seems to reach till here:

fsharp/src/Compiler/Interactive/fsi.fs

Line 2937 in ad65b81

let rec ExecuteParsedInteractionInGroups (ctok, istate, synInteraction, diagnosticsLogger: DiagnosticsLogger, lastResult: FsiValue option, cancellationToken: CancellationToken) =

I could not use it successfully.

Does it reach all the way to ControlledExecution.fs ? This class seems to have its own token. TryAbort:

fsharp/src/Compiler/Interactive/ControlledExecution.fs

Line 49 in ad65b81

member _.TryAbort(): unit =

I also tried to run my own ControlledExecution Class
but got the message Compiler Error:input.fsx (1,1)-(1,1) interactive error internal error: The thread is already executing the ControlledExecution.Run method.
Did I miss something ? Or is the token in the Eval method suposed to work and I might be using it wrongly ?

[vzarytovskii]

@KevinRansom what would be the proper way of doing that?

[goswinr]

@KevinRansom @vzarytovskii would you accept this commit as pull request to enable cancellation? goswinr@87f6534

[T-Gro]

How would that work in this scenario, i.e. how would we ensure (instrument?) to make sure the token is being checked and execution stopped?

Or do I imagine it wrongly that user code would continue to be running despite of this, unless the token is explicitly checked?

/// On net7.0 or later it uses a cancellation token in System.Runtime.ControlledExecution.Run()

[goswinr]

@T-Gro I am not sure if I understand your question. The token is internal here

fsharp/src/Compiler/Interactive/ControlledExecution.fs

Line 21 in e30d14c

let mutable cts: CancellationTokenSource voption = ValueNone

that is why I would like to make ‘TryAbort’ public. The build from my fork works for my use case. (cancelling an FSI session hosted in an WPF app)

[goswinr]

I created a pull request to enable this #14546

[goswinr]

solved by #15184