FSharpWorkspace prototype #17920
FSharpWorkspace prototype #17920
Conversation
| static member CreateFromString(filename: string, content: string) = | ||
| FSharpFileSnapshot( | ||
| filename, | ||
| Md5Hasher.hashString content |> Md5Hasher.toString, |
There was a problem hiding this comment.
Should probably eventually change to something more proper, can't ship with md5 hashing
There was a problem hiding this comment.
Most definitely. We should probably bring in some version of xxHash.
There was a problem hiding this comment.
Yeah. That was my thinking as well.
Yeah I just thought this might be a good point for people to start looking at it and poke holes or give advice on how to do it better. |
|
It would be nice if some NuGet packages could get attached to this PR (Upload artifact stuff in GitHub Actions). This would make it easier to play with in fsautocomplete for example. |
Yeah we can do that, but probably won't be final, since types/packages/namespaces/etc can change. |
|
I am still grasping the topic but...
How about ProjectProperties, ProjectPropertiesWithReferences and Project, respectively? Base and Core and honestly very obscure suffixes. Better go long! :D |
|
Summary
An F# workspace based on a dependency graph of files, projects, references.
It's kind of an early prototype but whoever is interested can already have a look and maybe give some useful feedback.
It can right now in VS-LSP deal with opening/closing/editing files, adding and removing files in projects, in-memory F# project references.
Public API so far
The user will create an instance of
FSharpWorkspaceand hold on to it. It's mutable and will be keeping the state of the workspace.They can add F# projects to it with:
AddCommandLineArgs(projectPath, outputPath, compilerArgs)They can update the projects if anything changes the same way. Just call
AddCommandLineArgswith the new arguments.-r:matchingoutputPath). SooutputPathhas to be provided correctly for in-memory references to work.They notify about files opening/closing/being edited by
OpenFile,CloseFile,ChangeFile.They can request
FSharpProjectSnapshotfor a given file and it will be lazily computed based on current state. The snapshot is still immutable and contains everything needed byFSharpCheckerto work with the file. Parts of it may be lazily computed (e.g. if we're only interested in parsing it will not compute hash of references).Some technical details
To save some hash re-computation I decide to further (internally) split
ProjectSnapshotintoProjectCore= everything except files and (in-memory) referencesProjectBase=ProjectCore+ (in-memory) referencesProjectSnapshot=ProjectBase+ source filesI need help with names! 😂
I've been trying to come up with the simplest model for lazy "reactive" computation for the workspace. Right now it's the
DependencyGraph. I don't love how it deals with different types of dependencies (DUs and "unpacking" them) but not sure how to solve it better without some sort of type-level programming 😅