Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable Transparent Compiler tests #17933

Draft
wants to merge 30 commits into
base: main
Choose a base branch
from
Draft

Conversation

majocha
Copy link
Contributor

@majocha majocha commented Oct 28, 2024

Experiment branched out from #17872

Async flavor of graph processing is simplified a bit and runs with Async.Parallel, given that it is async already.

If there are any remaining instabilities in Transparent Compiler tests they should be easier to weed out in a parallel test run, where the thread pool is way more stressed.

All the tests tests from #16766 but two should be unskipped, unless I missed some.

Copy link
Contributor

❗ Release notes required

@majocha,

Caution

No release notes found for the changed paths (see table below).

Please make sure to add an entry with an informative description of the change as well as link to this pull request, issue and language suggestion if applicable. Release notes for this repository are based on Keep A Changelog format.

The following format is recommended for this repository:

* <Informative description>. ([PR #XXXXX](https://github.com/dotnet/fsharp/pull/XXXXX))

See examples in the files, listed in the table below or in th full documentation at https://fsharp.github.io/fsharp-compiler-docs/release-notes/About.html.

If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

You can open this PR in browser to add release notes: open in github.dev

Change path Release notes path Description
src/FSharp.Core docs/release-notes/.FSharp.Core/9.0.200.md No release notes found or release notes format is not correct
src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.200.md No release notes found or release notes format is not correct

@majocha
Copy link
Contributor Author

majocha commented Oct 29, 2024

image
LruCache Count needs lock. I added a rudimentary fix.
image
This one I can reproduce locally, but unsure what's going on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: New
Development

Successfully merging this pull request may close these issues.

1 participant