Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spurious output in non-TL MSBuild repo build #10899

Closed
rainersigwald opened this issue Oct 28, 2024 · 1 comment
Closed

Spurious output in non-TL MSBuild repo build #10899

rainersigwald opened this issue Oct 28, 2024 · 1 comment
Assignees
@GangWang01
Labels
Area: Our Own Build Problems affecting the build or build infrastructure of the MSBuild repo itself. Priority:3 Work that is nice to have triaged

Comments

@rainersigwald
Copy link
Member

I had a totally flattened machine (so I didn't have TL on via env var for all builds) and I ran build.cmd -bl in our repo, which produce this output snippet

  MSBuildTaskHost -> S:\msbuild\artifacts\bin\MSBuildTaskHost\x64\Debug\net35\MSBuildTaskHost.exe
  CustomCheck -> S:\msbuild\artifacts\bin\CustomCheck\Debug\netstandard2.0\CustomCheck.dll
  CustomCheck2 -> S:\msbuild\artifacts\bin\CustomCheck2\Debug\netstandard2.0\CustomCheck2.dll
  ErrorCustomCheck -> S:\msbuild\artifacts\bin\ErrorCustomCheck\Debug\netstandard2.0\ErrorCustomCheck.dll
  InvalidCustomCheck -> S:\msbuild\artifacts\bin\InvalidCustomCheck\Debug\netstandard2.0\InvalidCustomCheck.dll
  Adding DLLs from the following packages:
  Adding DLLs from the following packages:
  Adding DLLs from the following packages:
  Adding DLLs from the following packages:
  Successfully created package 'S:\msbuild\artifacts\bin\Microsoft.Build.BuildCheck.UnitTests\CustomChecks\ErrorCustomCheck.1.0.0.nupkg'.
  Successfully created package 'S:\msbuild\artifacts\bin\Microsoft.Build.BuildCheck.UnitTests\CustomChecks\CustomCheck.1.0.0.nupkg'.
  Successfully created package 'S:\msbuild\artifacts\bin\Microsoft.Build.BuildCheck.UnitTests\CustomChecks\InvalidCustomCheck.1.0.0.nupkg'.
  Successfully created package 'S:\msbuild\artifacts\bin\Microsoft.Build.BuildCheck.UnitTests\CustomChecks\CustomCheck2.1.0.0.nupkg'.
  Microsoft.Build.UnitTests.Shared -> S:\msbuild\artifacts\bin\Microsoft.Build.UnitTests.Shared\Debug\net472\Microsoft.Build.UnitTests.Shared.dll
  Microsoft.Build.Framework.UnitTests -> S:\msbuild\artifacts\bin\Microsoft.Build.Framework.UnitTests\Debug\net472\Microsoft.Build.Framework.UnitTests.dll

The "adding DLLs" thing comes from

msbuild/src/BuildCheck.UnitTests/TestAssets/Common/CommonTest.targets

Line 23 in b1ae836

<Message Importance="High" Text="Adding DLLs from the following packages: @(_PackagesToPack->'%(NuGetPackageId)')" />

This makes me ask two questions:

  1. Why is this running in our own build?
  2. Why is this message so important?
@rainersigwald rainersigwald added the Area: Our Own Build Problems affecting the build or build infrastructure of the MSBuild repo itself. label Oct 28, 2024
@maridematte maridematte added Priority:3 Work that is nice to have triaged labels Oct 29, 2024
@GangWang01 GangWang01 assigned GangWang01 and unassigned GangWang01 Nov 13, 2024
@GangWang01 GangWang01 self-assigned this Dec 2, 2024
@GangWang01 GangWang01 mentioned this issue Dec 20, 2024
Closed
@GangWang01
Copy link
Member

The message was removed by #11208.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GangWang01 GangWang01

Labels
Area: Our Own Build Problems affecting the build or build infrastructure of the MSBuild repo itself. Priority:3 Work that is nice to have triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove empty message for adding DLLs from Nuget packages while packing GangWang01/msbuild
3 participants
@GangWang01 @rainersigwald @maridematte