[Perf] Windows/x86: 3 Improvements on 7/6/2023 1:53:22 PM

[performanceautofiler]

Run Information

Name	Value
Architecture	x86
OS	Windows 10.0.18362
Queue	TigerWindows
Baseline	9ea317f17d1ef5988921f611f80834d15a3e8070
Compare	0224f86a886e0aaf72acb6a4f5573236ba929292
Diff	Diff
Configs	CompilationMode:tiered, RunKind:micro

Improvements in System.Text.Perf_Ascii

Benchmark	Baseline	Test	Test/Base	Test Quality	Edge Detector	Baseline IR	Compare IR	IR Ratio
Equals_Chars - Duration of single invocation	13.19 ns	12.18 ns	0.92	0.46	False
Equals_Bytes_Chars - Duration of single invocation	15.94 ns	10.40 ns	0.65	0.27	False	178.06978760392533	109.70587233406626	0.6160835805458552)
Equals_Bytes - Duration of single invocation	8.28 ns	6.92 ns	0.84	0.33	False	100.81087851184267	88.93195819201219	0.882166285075722)

Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Text.Perf_Ascii*'

Payloads

Baseline
Compare

System.Text.Perf_Ascii.Equals_Chars(Size: 128)

ETL Files

Baseline
Compare

Histogram

Description of detection logic

IsRegressionBase: Marked as not a regression because the compare was not 5% greater than the baseline, or the value was too small.
IsImprovementBase: Marked as improvement because the compare was 5% less than the baseline, and the value was not too small.
IsImprovementCheck: Marked as improvement because the three check build points were 0.05 less than the baseline.
IsRegressionBase: Marked as not a regression because the compare was not 5% greater than the baseline, or the value was too small.
IsImprovementBase: Marked as improvement because the compare was 5% less than the baseline, and the value was not too small.
IsImprovementCheck: Marked as improvement because the three check build points were 0.05 less than the baseline.
IsImprovementWindowed: Marked as improvement because 12.1797787645276 < 12.881328863833888.
IsChangePoint: Marked as a change because one of 5/11/2023 1:19:27 PM, 7/6/2023 4:13:54 AM, 7/10/2023 9:23:13 PM falls between 7/1/2023 10:14:52 PM and 7/10/2023 9:23:13 PM.
IsImprovementStdDev: Marked as improvement because 9.144183795461718 (T) = (0 -11.315252204817396) / Math.Sqrt((1.8551249259972662 / (215)) + (0.48569162870324506 / (13))) is greater than 1.9705162426829501 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (215) + (13) - 2, .975) and 0.14770622944232834 = (13.276234786291605 - 11.315252204817396) / 13.276234786291605 is greater than 0.05.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

JIT Disasms

Baseline
Compare
Diff

System.Text.Perf_Ascii.Equals_Bytes_Chars(Size: 128)

ETL Files

Baseline
Compare

Histogram

Description of detection logic

IsRegressionBase: Marked as not a regression because the compare was not 5% greater than the baseline, or the value was too small.
IsImprovementBase: Marked as improvement because the compare was 5% less than the baseline, and the value was not too small.
IsImprovementCheck: Marked as improvement because the three check build points were 0.05 less than the baseline.
IsRegressionBase: Marked as not a regression because the compare was not 5% greater than the baseline, or the value was too small.
IsImprovementBase: Marked as improvement because the compare was 5% less than the baseline, and the value was not too small.
IsImprovementCheck: Marked as improvement because the three check build points were 0.05 less than the baseline.
IsImprovementWindowed: Marked as improvement because 10.39898195415345 < 14.92275128471626.
IsChangePoint: Marked as a change because one of 5/11/2023 1:19:27 PM, 7/6/2023 4:13:54 AM, 7/10/2023 9:23:13 PM falls between 7/1/2023 10:14:52 PM and 7/10/2023 9:23:13 PM.
IsImprovementStdDev: Marked as improvement because 42.680214501846656 (T) = (0 -10.418979634775097) / Math.Sqrt((1.2541397439916704 / (215)) + (0.2293302632644102 / (13))) is greater than 1.9705162426829501 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (215) + (13) - 2, .975) and 0.3856049717701993 = (16.958111892269596 - 10.418979634775097) / 16.958111892269596 is greater than 0.05.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

JIT Disasms

Baseline
Compare
Diff

System.Text.Perf_Ascii.Equals_Bytes(Size: 128)

ETL Files

Baseline
Compare

Histogram

Description of detection logic

IsRegressionBase: Marked as not a regression because the compare was not 5% greater than the baseline, or the value was too small.
IsImprovementBase: Marked as improvement because the compare was 5% less than the baseline, and the value was not too small.
IsImprovementCheck: Marked as improvement because the three check build points were 0.05 less than the baseline.
IsRegressionBase: Marked as not a regression because the compare was not 5% greater than the baseline, or the value was too small.
IsImprovementBase: Marked as improvement because the compare was 5% less than the baseline, and the value was not too small.
IsImprovementCheck: Marked as improvement because the three check build points were 0.05 less than the baseline.
IsImprovementWindowed: Marked as improvement because 6.9221504055473035 < 7.685965868663086.
IsChangePoint: Marked as a change because one of 5/11/2023 1:19:27 PM, 7/6/2023 4:13:54 AM, 7/10/2023 9:23:13 PM falls between 7/1/2023 10:14:52 PM and 7/10/2023 9:23:13 PM.
IsImprovementStdDev: Marked as improvement because 7.7230242597889935 (T) = (0 -7.163249107645408) / Math.Sqrt((1.3002807995333439 / (215)) + (0.5422656659177095 / (13))) is greater than 1.9705162426829501 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (215) + (13) - 2, .975) and 0.19068966001749751 = (8.851053488085027 - 7.163249107645408) / 8.851053488085027 is greater than 0.05.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

JIT Disasms

Baseline
Compare
Diff

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

[BrennanConroy]

This looks like dotnet/runtime#87141
Big perf gain in Equals_Bytes_Chars as expected, and smaller gains in Equals_Chars and Equals_Bytes due to removal of extra OR.