Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is it possible to disable nullable context errors through .editorconfig? #48840

Closed
bpaczkowski opened this issue Oct 22, 2020 · 2 comments
Closed
Labels
Area-Analyzers untriaged Issues and PRs which have not yet been triaged by a lead

Comments

@bpaczkowski
Copy link

I'm not entirely sure this is the correct repository to post this but here we go. We're using nullable context in all our new apps along with <WarningsAsErrors>nullable</WarningsAsErrors>. But it seems that without any changes to the project itself, it is possible to make a project compile by ignoring those checks entirely if one were to ignore them in .editorconfig, while these checks should prevent just that and should error out during compilation. Shouldn't it be the other way around? As in the more generic .editorconfig can be overridden in the more specific csproj?

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Oct 22, 2020
@jaredpar
Copy link
Member

@mavasani @chsienki to clarify the precedent of the various configurations here.

@mavasani
Copy link
Contributor

mavasani commented Oct 23, 2020

This was fixed with #48125 (will first release in 16.9 Preview1). The new precedence rules after that PR are documented at https://docs.microsoft.com/dotnet/fundamentals/code-analysis/configuration-files#precedence

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Analyzers untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

No branches or pull requests

4 participants