Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve "Post merge" instructions in Readme #239

Open
carlossanlop opened this issue Apr 13, 2022 · 1 comment
Open

Improve "Post merge" instructions in Readme #239

carlossanlop opened this issue Apr 13, 2022 · 1 comment
Assignees

Comments

@carlossanlop
Copy link
Member

@ViktorHofer explained the process after merging a new package. We need to add those instructions in the readme "post merge" section: https://github.com/dotnet/runtime-assets#2-post-merge

Summarized:

  • After merge, wait for the pipeline to finish and the packages get published to Darc.
  • Look at the runtime-assets-official artifacts list, the new package should be there.
  • Copy the version of the package.
  • In the runtime repo, add entries for the new package to Versions.props and to Versions.Details.xml
@carlossanlop carlossanlop self-assigned this Apr 13, 2022
@ViktorHofer
Copy link
Member

Sounds good. But I would not share any links to internal builds or the public dotnet7-transport feed as that is subject to change. I would just call them out but not link to them as currently done in the instructions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants