Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jitstress failure from recent pred list changes #80974

Closed
AndyAyersMS opened this issue Jan 21, 2023 · 2 comments · Fixed by #80975
Closed

jitstress failure from recent pred list changes #80974

AndyAyersMS opened this issue Jan 21, 2023 · 2 comments · Fixed by #80975
Assignees
@AndyAyersMS
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI blocking-clean-ci-optional Blocking optional rolling runs JitStress CLR JIT issues involving JIT internal stress modes
Milestone
8.0.0

Comments

@AndyAyersMS
Copy link
Member

This is affecting about 150 test executions in jitstress and some in libraries jitstress too

Assert failure(PID 28 [0x0000001c], Thread: 41 [0x0029]): Assertion failed 'topBB->bbNum <= botBB->bbNum' in 'FsCheck.TypeClass+FromType@48:Invoke(System.Type):bool:this' during 'Set block order' (IL size 9; hash 0xf9ed1197; Tier0-FullOpts-MinOpts)

    File: /__w/1/s/src/coreclr/jit/optimizer.cpp Line: 4695
    Image: /root/helix/work/correlation/dotne

There is an assert in optReachWithoutCall invoked by fgSetBlockOrder that is triggered because we no longer have bbNum order in some unoptimized compiles. Turns out we don't actually depend on block order so I think I can just defer the assert.
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jan 21, 2023
@AndyAyersMS AndyAyersMS self-assigned this Jan 21, 2023
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Jan 21, 2023
@ghost
Copy link

ghost commented Jan 21, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak
See info in area-owners.md if you want to be subscribed.

Issue Details

This is affecting about 150 test executions in jitstress and some in libraries jitstress too

Assert failure(PID 28 [0x0000001c], Thread: 41 [0x0029]): Assertion failed 'topBB->bbNum <= botBB->bbNum' in 'FsCheck.TypeClass+FromType@48:Invoke(System.Type):bool:this' during 'Set block order' (IL size 9; hash 0xf9ed1197; Tier0-FullOpts-MinOpts)

    File: /__w/1/s/src/coreclr/jit/optimizer.cpp Line: 4695
    Image: /root/helix/work/correlation/dotne

There is an assert in optReachWithoutCall invoked by fgSetBlockOrder that is triggered because we no longer have bbNum order in some unoptimized compiles. Turns out we don't actually depend on block order so I think I can just defer the assert.

Author: AndyAyersMS
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: -

@AndyAyersMS AndyAyersMS added this to the 8.0.0 milestone Jan 21, 2023
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Jan 21, 2023
@AndyAyersMS
Copy link
Member Author

Likely caused by #80891

AndyAyersMS added a commit to AndyAyersMS/runtime that referenced this issue Jan 21, 2023
@AndyAyersMS
JIT: fix jit stress failures in fgSetBlockOrder
6220f50 
Defer asserting that bbNums are ordered until we know if we're optimizing
(and hence have computed dominators).

Fixes dotnet#80974.
@AndyAyersMS AndyAyersMS mentioned this issue Jan 21, 2023
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jan 21, 2023
@AndyAyersMS AndyAyersMS added JitStress CLR JIT issues involving JIT internal stress modes blocking-clean-ci-optional Blocking optional rolling runs labels Jan 21, 2023
AndyAyersMS added a commit that referenced this issue Jan 21, 2023
@AndyAyersMS
JIT: fix jit stress failures in fgSetBlockOrder (#80975)
2f2215f 
Defer asserting that bbNums are ordered until we know if we're optimizing
(and hence have computed dominators).

Fixes #80974.
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jan 21, 2023
mdh1418 pushed a commit to mdh1418/runtime that referenced this issue Jan 24, 2023
@AndyAyersMS @mdh1418
JIT: fix jit stress failures in fgSetBlockOrder (dotnet#80975)
5531f10 
Defer asserting that bbNums are ordered until we know if we're optimizing
(and hence have computed dominators).

Fixes dotnet#80974.
@ghost ghost locked as resolved and limited conversation to collaborators Feb 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@AndyAyersMS AndyAyersMS

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI blocking-clean-ci-optional Blocking optional rolling runs JitStress CLR JIT issues involving JIT internal stress modes
Projects
None yet
Milestone
8.0.0
Development

Successfully merging a pull request may close this issue.

JIT: fix jit stress failures in fgSetBlockOrder AndyAyersMS/runtime
1 participant
@AndyAyersMS