Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NET SDK Finalizer Feature Band calculation doesn't match SDK's calculation #43876

Open
dsplaisted opened this issue Oct 3, 2024 · 0 comments
Labels
Area-NetSDK untriaged Request triage from a team member

Comments

@dsplaisted
Copy link
Member

In the SDK, when calculating the feature band, we look for whether several strings (including rtm) are contained in the prerelease string:

if (string.IsNullOrEmpty(version.Prerelease) || version.Prerelease.Contains("dev") || version.Prerelease.Contains("ci") || version.Prerelease.Contains("rtm"))

In the finalizer, it looks like we are checking to see that one of the prerelease segments matches the list of strings, and we aren't including rtm in the list.

if ((CSTR_EQUAL != ::CompareStringW(LOCALE_INVARIANT, 0, rgsczPrereleaseParts[0], -1, L"dev", -1)) &&
(CSTR_EQUAL != ::CompareStringW(LOCALE_INVARIANT, 0, rgsczPrereleaseParts[0], -1, L"ci", -1)))

This means that the feature bands for versions like the following won't be calculated correctly in the finalizer:

  • 9.0.100-servicing.12345.6
  • 9.0.100-rtm.12345.6

This means that for SDKs with these non-stabilized version numbers, we won't correctly uninstall workload sets in the finalizer when the .NET SDK is uninstalled.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-NetSDK untriaged Request triage from a team member labels Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-NetSDK untriaged Request triage from a team member
Projects
None yet
Development

No branches or pull requests

1 participant