-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating the Microsoft Extensions packages to 8.0 versions #8579
base: release/8.0.1xx
Are you sure you want to change the base?
Conversation
…e pulling in an old version of STJ
@dotnet/source-build I have added these versions of the packages to SBRP(#1087), can you review them? |
We cannot have 8.0 versions of SBRP packages in 8.0 branches. SBRP PR should be closed. You'd need to add explicit package references to |
@NikolaMilosavljevic I added these three to eng\version.details.xml. However, this repo already was using different packages for the source build build: https://github.com/dotnet/templating/blob/release/8.0.1xx/eng/Package.props#L7 I used a different property for these new ones as I didn't want to impact that but I also don't understand why source build flagged this at all since it should have been using the versions in package.props instead of the ones in dependabot\packages.props. |
@NikolaMilosavljevic SB is still complaining about 4 prebuilts including one I added to version.details.xml. Do I have to add all of them and any idea about Microsoft.Extensions.Logging.Abstractions.8.0.2 |
Yeah, you'd now add these prebuilts to exclusion file You'd also need to add package dependency for |
Thanks @NikolaMilosavljevic. It's passing checks now. Would you mind taking a quick look to ensure that Jason got all of the steps right. It looks right to me now. |
they are pulling in an old version of STJ