Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CDN endpoint #8595

Merged
merged 2 commits into from
Dec 22, 2024
Merged

Update CDN endpoint #8595

merged 2 commits into from
Dec 22, 2024

Conversation

joeloff
Copy link
Member

@joeloff joeloff commented Dec 16, 2024

No description provided.

@joeloff joeloff requested a review from a team as a code owner December 16, 2024 23:11
@marcpopMSFT
Copy link
Member

Wait to January to merge as it'll get picked up in the pipeline right away and we don't want to risk it

@richlander
Copy link
Member

Which .NET SDK branches will this change get applied to?

@baronfel
Copy link
Member

baronfel commented Dec 20, 2024

This only applies to the main branch.

The only hardcoded urls are part of a backend content generation process, the results of which are downloaded by user SDK installations through another redirect that isn't subject to the work we have to do for this one. This process only happens out of main (and maintaining the compatibility of the results is a constraint that we have to operate under).

@richlander
Copy link
Member

I see. I hear you saying that the scope here is very narrow. That's good.

@richlander
Copy link
Member

We will want to consider moving to a vanity domain instead of AFD directly. We can discuss that offline. If it's worth using a CDN, it is likely worth using a vanity domain.

@baronfel baronfel merged commit 3d78d07 into dotnet:main Dec 22, 2024
10 checks passed
@baronfel
Copy link
Member

baronfel commented Dec 22, 2024

Went ahead and merged this because we want to use templating as a low-blast-radius test of the AFD infrastructure to inform some decision making happening on Monday. @marcpopMSFT I added you to the internal thread discussing this for the full context.

@richlander
Copy link
Member

dotnet/core#9671

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants