-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config: Update Dockerfile to use Alpine image as a base #2
base: master
Are you sure you want to change the base?
Conversation
… Python and Ruby Co-authored-by: Victoria-Mag <[email protected]> Co-authored-by: KuzzyKabana <[email protected]>
Dockerfile
Outdated
RUN pip3 install --no-cache --upgrade pip setuptools | ||
|
||
# Get speaker-verification repo | ||
RUN git clone https://github.com/OnTrack-UG-Squad/speaker-verification.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you need to install any dependencies for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I'll need to update it to make the virtual environment and install the requirements.txt stuff, as per the main speaker-verification readme instructions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than going about the virtual environment stuff, we've just gone ahead and installed the dependencies. The docker container doesn't really need things to be kept in a virtual environment from what I can see.
We have since run into problems on the speaker-verification side of things. It appears some packages have since been updated and are now causing problems which we will have to investigate.
Co-authored-by: Victoria-Mag <[email protected]> Co-authored-by: KuzzyKabana <[email protected]>
0993820
to
d5e2f13
Compare
RUN pip3 install --no-cache --upgrade pip setuptools | ||
|
||
# Get speaker-verification repo | ||
RUN git clone -b fix/logger-issues https://github.com/OnTrack-UG-Squad/speaker-verification.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is temporary until speaker-verification side of things is fixed.
Co-authored-by: Victoria-Mag <[email protected]> Co-authored-by: KuzzyKabana <[email protected]>
Co-authored-by: Victoria-Mag <[email protected]> Co-authored-by: KuzzyKabana <[email protected]>
Fixes #1
Proposed Changes
Co-authored-by: Victoria-Mag [email protected]
Co-authored-by: KuzzyKabana [email protected]