Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: Update Dockerfile to use Alpine image as a base #2

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

kugamigh
Copy link
Contributor

Fixes #1

Proposed Changes

  • Update Dockerfile to use Alpine base image
  • Remove extra Dockerfiles not in use

Co-authored-by: Victoria-Mag [email protected]
Co-authored-by: KuzzyKabana [email protected]

Dockerfile Outdated
RUN pip3 install --no-cache --upgrade pip setuptools

# Get speaker-verification repo
RUN git clone https://github.com/OnTrack-UG-Squad/speaker-verification.git
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you need to install any dependencies for this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'll need to update it to make the virtual environment and install the requirements.txt stuff, as per the main speaker-verification readme instructions.

https://github.com/OnTrack-UG-Squad/speaker-verification

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than going about the virtual environment stuff, we've just gone ahead and installed the dependencies. The docker container doesn't really need things to be kept in a virtual environment from what I can see.

We have since run into problems on the speaker-verification side of things. It appears some packages have since been updated and are now causing problems which we will have to investigate.

@kugamigh kugamigh force-pushed the config/update-docker-image branch from 0993820 to d5e2f13 Compare September 18, 2021 08:39
@kugamigh kugamigh marked this pull request as ready for review September 18, 2021 08:40
@kugamigh kugamigh requested a review from macite September 18, 2021 08:41
RUN pip3 install --no-cache --upgrade pip setuptools

# Get speaker-verification repo
RUN git clone -b fix/logger-issues https://github.com/OnTrack-UG-Squad/speaker-verification.git
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is temporary until speaker-verification side of things is fixed.

@kugamigh kugamigh marked this pull request as draft September 19, 2021 04:14
kugamigh and others added 2 commits September 23, 2021 16:44
Co-authored-by: Victoria-Mag <[email protected]>
Co-authored-by: KuzzyKabana <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Dockerfile to use Alpine base image
2 participants