Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[useMultipleSelection] getDropdownProps doesn't call consumer supplied handlers when preventKeyAction is true #1615

Open
juzerzarif opened this issue Jul 19, 2024 · 0 comments

Comments

@juzerzarif
Copy link

When preventKeyAction is true for getDropdownProps it omits its own onKeyDown and onClick handlers but it also omits any keydown or click handler that the caller may have provided:

...(!preventKeyAction && {
onKeyDown: callAllEventHandlers(onKeyDown, dropdownHandleKeyDown),
onClick: callAllEventHandlers(onClick, dropdownHandleClick),
}),

I think a more predictable behavior would be to call the handlers supplied by the consumer regardless of preventKeyAction (they might have nothing to do with key actions).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant