Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make AnyUrl type available again #244

Open
Ratgor opened this issue Apr 28, 2023 · 0 comments
Open

make AnyUrl type available again #244

Ratgor opened this issue Apr 28, 2023 · 0 comments

Comments

@Ratgor
Copy link

Ratgor commented Apr 28, 2023

I had to patch the last versions of pandasdmx in a project
because I need to support extra url formats validation
(urls without top-level domain or http/https schema)

As I noticed AnyUrl had been used instead of HttpUrl in earlier versions.

e.g. for the latest v1.10
in the file site-packages/pandasdmx/source/__init__.py
line 0: from pydantic import HttpUrl -> from pydantic import HttpUrl, AnyUrl # PATCH: AnyUrl added to support extra url formats
line 33: url: Optional[HttpUrl] -> url: Optional[AnyUrl] # PATCH: AnyUrl forced instead of HttpUrl to support extra url formats

Q1: will the AnyUrl be back again? (by default or as an option)
Q2: should I make a PR here with my changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant