-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error handling according to fixed set of relations for play-spoken-text #275
Comments
For roles, I don't think there is a set of fixed values. Correct me if I'm wrong, @lehkost. For the |
Yes, I think roles (so far only used in RomDraCor and GreekDraCor, if I'm not mistaken) will remain the current set of fixed values. Extending the discussion to @juliajbeine, who might shed some more light on this. |
This is the list of role values used in RomDraCor:
It wouldn't seem like a good general purpose classification of roles. Not even for GreekDraCor, which currently hasn't any roles assigned to |
Thanks, we also quantified and visualised roles for RomDraCor in Figure 1 of our recent DH2024 paper "Just the Type" (doi:10.5281/zenodo.13801481), maybe interesting in this regard. But now I'll leave the rest to @juliajbeine. |
An idea regarding the role values: I would suggest that such specific taxonomies must be declared somewhere before used in the encoding and not just put into the TEIs. If corpus editors can agree on a fixed set than they could be declared as a in the in the corpus.xml (I haven't checked the the validity, this is just a quick take). The API could then at least check if the value is part of the taxonomy and if not, return an error. But yes, as Carsten suggested, we should discuss that in the schema/odd issue, if there is one. |
The role attribute is relevant to the (tragi-)comedies in RomDraCor, GreekDraCor, and NeoLatDraCor as they feature stock characters. @lehkost and I discussed how to make this information available for digital analyses and came up with the role attribute. The associated commits are: The roles are based on the information given in the editions themselves. For NeoLatDraCor, see I also included this information in the NeoLatDraCor wiki: The role description may differ between editions. For instance, one may discuss whether puella and virgo are synonyms. My suggestion would be to stick to the information given in the text editions, especially since the NeoLatDraCor is currently built and we do not know all possible values for the role attribute yet. Later, we may discuss whether to revise the values for unification. Another comment: Mercurius should rather have the role attributes deus AND prologus, so two values. (The same would apply to the god Pan in Menander's Dyskolos. @lehkost and I plan to generally update the TEI files in GreekDraCor, also adding the information on stock characters to Menander's Dyskolos.) |
Please create taxonomies for these values, this would be a semantically sound solution for such research-driven markup. |
From what @juliajbeine describes as the current state of affairs I think it is clear that a fixed list of I opened a ticket to document this current usage. For an alternative of dealing with roles in the future also see dracor-org/dracor-schema#81 (comment). For the issue at hand here this still leaves the question whether or not the DraCor API should expect a finite choice of values for the |
In the endpoint
/corpora/{corpusname}/plays/{playname}/spoken-text
for the parameter relation a fixed set of possible values is indicated in the API documentation. When I pass a parameter that is not in the list an empty string is returned. It would be good to get an error (similar to the gender parameter) in which the possible set of values is indicated.The same would be good for the parameter role or is this not a fixed set of values?
The text was updated successfully, but these errors were encountered: