Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop car from charging #8

Open
Tschingis opened this issue Jun 17, 2019 · 4 comments
Open

Stop car from charging #8

Tschingis opened this issue Jun 17, 2019 · 4 comments

Comments

@Tschingis
Copy link

Thanks for your great work. This is not directly an issue but more something i found out. As you have written in the code, protocol 2 does not allow to stop a car from charging. Using the car api does not work for me since there are non tesla cars charging at the twc. By accident i have seen that if the twcmanager script was not running, the twc goes into a resumable error state (Green on - 4 Red flashes) and it does not charge the car. It even stops the charge of the car, if you terminate the script during a charge. I made a dirty hack into the script which does not send a master heartbeat to a slave twc if it is not allowed to charge. I cannot test if this hack works with several slaves, i.e. if a slave keeps charging if he receives a heartbeat that is not adressed to him, but in case of one slave (one twc) it reproducable prevents charging of the car. If the heartbeat starts again, the charging of the car resumes.

@simotronic
Copy link

That's an interesting observation especially with respect to non-Tesla vehicles. I have been asked to investigate the communications to the vehicle and adding a means where a non-Tesla vehicle can be identified, and potentially qualified to charge. Very applicable in shared parking locations!

@infernix
Copy link

infernix commented Sep 4, 2019

@Tschingis would you mind forking this and committing your hack? Or at least paste a diff here?

@laur3ns
Copy link

laur3ns commented Sep 24, 2019

I believe the trouble with this approach is that if the time window in which it is not receiving heartbeats is too long, the TWC and/or car (the latter if I recall) will go into a permanent error state, requiring a re plug to clear.

@db9carbon
Copy link

Thanks for your great work. This is not directly an issue but more something i found out. As you have written in the code, protocol 2 does not allow to stop a car from charging. Using the car api does not work for me since there are non tesla cars charging at the twc. By accident i have seen that if the twcmanager script was not running, the twc goes into a resumable error state (Green on - 4 Red flashes) and it does not charge the car. It even stops the charge of the car, if you terminate the script during a charge. I made a dirty hack into the script which does not send a master heartbeat to a slave twc if it is not allowed to charge. I cannot test if this hack works with several slaves, i.e. if a slave keeps charging if he receives a heartbeat that is not adressed to him, but in case of one slave (one twc) it reproducable prevents charging of the car. If the heartbeat starts again, the charging of the car resumes.

I too am looking for this, as using TWC on non-Tesla's too. Can you pls post your code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants