Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add imagePullSecrets support for Custom Resources #197

Open
jurim76 opened this issue Jun 6, 2024 · 6 comments
Open

Add imagePullSecrets support for Custom Resources #197

jurim76 opened this issue Jun 6, 2024 · 6 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@jurim76
Copy link

jurim76 commented Jun 6, 2024

CRD supports image value only with predefined external registry.
Sometimes access to registry is restricted to internal registry only, in this case you need to define imagePullSecrets or modify serviceAccount.

@Pothulapati Pothulapati added good first issue Good for newcomers help wanted Extra attention is needed labels Jun 12, 2024
@Aym3nTN
Copy link
Contributor

Aym3nTN commented Jul 5, 2024

@jurim76 Can you provide more details? I'd like to help on this one

@jurim76
Copy link
Author

jurim76 commented Jul 12, 2024

CR should support imagePullSecrets directive

For example
Define in CR yaml

image: "some.local.repo/dragonfly:v1.20.1"
imagePullSecrets:
  - name: regcred

The image will be pulled from some.local.repo, using "regcred" secret

@artsenko-cyco
Copy link

hi @Aym3nTN
any ETA?

@mircea-pavel-anton
Copy link

mircea-pavel-anton commented Sep 12, 2024

I am also currently blocked by this, unable to even deploy an instance in my cluster since images from public repositories are not allowed...

@Aym3nTN Can I provide any assistance on this? Are you still working on it?

@Aym3nTN
Copy link
Contributor

Aym3nTN commented Sep 12, 2024

@mircea-pavel-anton I hadn't make significant progress. Feel free to work on it.

@mircea-pavel-anton
Copy link

I'll see if I can get something going sometime later next week!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants