Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RegTests with epoll failrues #4450

Open
7 tasks
kostasrim opened this issue Jan 14, 2025 · 3 comments
Open
7 tasks

RegTests with epoll failrues #4450

kostasrim opened this issue Jan 14, 2025 · 3 comments
Labels
bug Something isn't working failing-test

Comments

@kostasrim
Copy link
Contributor

kostasrim commented Jan 14, 2025

See https://github.com/dragonflydb/dragonfly/actions/runs/12764061257/job/35575450779#step:6:3437

  • test_migration_timeout_on_sync
  • test_network_disconnect_during_migration
  • test_cluster_migration_huge_container
  • test_reply_count
  • test_big_containers
  • test_cluster_migration_while_seeding
  • test_denyoom_commands

For test_big_containers it would almost never finish because of a bug within the epoll socket (romange/helio#363). After the fix, locally the memory does not surpass 1.4x (dropped from 2x) but it seems that on the CI it still fails with (2x). I also:

  • compared the INFO MEMORY from both EPOLL and IOURING leading to very similar memory footprints for both variants
  • calculated the total allocations and deallocations with the memory tracker for both EPOLL and IOURING and both of them had very similar results

I suspect there is something around the EPOLL socket operations that "wastes" memory but we need to somehow narrow it down

@kostasrim kostasrim added bug Something isn't working failing-test labels Jan 14, 2025
@kostasrim kostasrim changed the title RegTests with epoll failrues: RegTests with epoll failrues Jan 14, 2025
@kostasrim
Copy link
Contributor Author

Full list of skipped tests: https://github.com/dragonflydb/dragonfly/pull/4426/files

@kostasrim
Copy link
Contributor Author

@kostasrim
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working failing-test
Projects
None yet
Development

No branches or pull requests

1 participant