From e5a01ebfe116354779136a8319323d2b2b27e3eb Mon Sep 17 00:00:00 2001 From: adi_holden Date: Wed, 13 Nov 2024 13:57:22 +0200 Subject: [PATCH 1/3] feat server: experimental_new_io flag add as deprecated Signed-off-by: adi_holden --- src/facade/conn_context.cc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/facade/conn_context.cc b/src/facade/conn_context.cc index 9879383765fe..fb9d9cdaed1e 100644 --- a/src/facade/conn_context.cc +++ b/src/facade/conn_context.cc @@ -10,6 +10,8 @@ #include "facade/dragonfly_connection.h" #include "facade/reply_builder.h" +ABSL_FLAG(bool, experimental_new_io, true, "the flag is deprecated"); + namespace facade { ConnectionContext::ConnectionContext(Connection* owner) : owner_(owner) { From 611ad942a7c6979624d469fd96c4fe40bdf063c3 Mon Sep 17 00:00:00 2001 From: adi_holden Date: Wed, 13 Nov 2024 14:45:42 +0200 Subject: [PATCH 2/3] use ABSL_RETIRED_FLAG Signed-off-by: adi_holden --- src/facade/conn_context.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/facade/conn_context.cc b/src/facade/conn_context.cc index fb9d9cdaed1e..518d89378ba4 100644 --- a/src/facade/conn_context.cc +++ b/src/facade/conn_context.cc @@ -10,7 +10,9 @@ #include "facade/dragonfly_connection.h" #include "facade/reply_builder.h" -ABSL_FLAG(bool, experimental_new_io, true, "the flag is deprecated"); +ABSL_RETIRED_FLAG(bool, experimental_new_io, true, + "Use new replying code - should " + "reduce latencies for pipelining"); namespace facade { From 86aee8a26d3246a447a80b94c82fd8987d9c8bd7 Mon Sep 17 00:00:00 2001 From: adi_holden Date: Wed, 13 Nov 2024 14:58:27 +0200 Subject: [PATCH 3/3] add todo Signed-off-by: adi_holden --- src/facade/conn_context.cc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/facade/conn_context.cc b/src/facade/conn_context.cc index 518d89378ba4..fa10135246ea 100644 --- a/src/facade/conn_context.cc +++ b/src/facade/conn_context.cc @@ -12,10 +12,9 @@ ABSL_RETIRED_FLAG(bool, experimental_new_io, true, "Use new replying code - should " - "reduce latencies for pipelining"); + "reduce latencies for pipelining"); // TODO remove in 1/2/25 namespace facade { - ConnectionContext::ConnectionContext(Connection* owner) : owner_(owner) { conn_closing = false; req_auth = false;