Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update image to support TLS 1.3 #17

Closed
r3pek opened this issue Nov 22, 2020 · 7 comments
Closed

Update image to support TLS 1.3 #17

r3pek opened this issue Nov 22, 2020 · 7 comments

Comments

@r3pek
Copy link

r3pek commented Nov 22, 2020

What the tittle says. Right now, if connection to a TLS1.3 only server, we get this message:

2020/11/05 22:56:49 failed to authenticate user: Post https://xxxxxxxxx/_matrix/client/r0/login: remote error: tls: protocol version not supported

@tboerger
Copy link
Contributor

Not sure what needs to be done here, I guess an updated Go version to compile the plugin?

@r3pek
Copy link
Author

r3pek commented Nov 22, 2020 via email

@donny-dont
Copy link
Contributor

Please do a local build of #18 and see if this solves your problem. I don't use matrix so I can't verify it works.

@r3pek
Copy link
Author

r3pek commented Nov 26, 2020

@donny-dont not really sure how i can test this :-/
btw, i guess all images have this problem (just hit it with the docker plugin too). should i open an issue on everyone?

@donny-dont
Copy link
Contributor

You would need to build the executable and see if it connects to your server.

go build ./cmd/drone-matrix

Will make an exe. You can then run ./drone-matrix --help to get a list of options. You should see options that correspond to the settings values. Run it and see if it works.

With the docker one things might be tricky for you drone-plugins/drone-docker#244 so you should probably not use TLS 1.3 exclusively if you have a local registry. But yea you can open the bug.

@r3pek
Copy link
Author

r3pek commented Nov 26, 2020

Tested it and it works (built with go 1.14.10)

I don't have a private registry, so, it's only the "connecting to" part i'm worried. ;)

@tboerger
Copy link
Contributor

This should be fixed by #18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants