-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge your code to impacket examples #1
Comments
I think this could be worth pursuing. There was a recent tool release from @zblurx that deals with LAPS 2.0 (https://gist.github.com/zblurx/009633b2db25918bdbbff664a01508fc) that I would love to integrate into the larger project so that both versions are handled. We will see! |
I implement everything about LAPSv2 in fortra/impacket#1556 PR to Impacket |
@zblurx - I have been integrating your code into my example. I'm in the process of setting up a lab on my ESXi to test it out and make sure I'm parsing everything properly. If things work out and I like it, I'll commit it to this repo and let you take a look at it before submitting a PR to the impacket repo. Hopefully we'll have something that pulls both versions of LAPS passwords in one tool! |
@zblurx - I have implemented your code in a super dirty way, but it works! |
@CaledoniaProject - I have submitted a PR to this fork of impacket. zblurx/impacket#1 If everything is good with the original author, I would hope to get the entire example script submitted via a PR to the official impacket repo. It's out of my hands now. |
Closing this issue now! There's nothing more I can do. |
Hi @dru1d-foofus, is it merged or not ... |
Nope! It's been in review since August; there's a link to the PR earlier on in the thread. @zblurx and I have done everything we can and the rest is on Fortra. |
Can you merge your code to impacket examples folder?
The text was updated successfully, but these errors were encountered: