Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@amazee/react-scripts – npm #398

Closed
signalwerk opened this issue Mar 20, 2018 · 5 comments
Closed

@amazee/react-scripts – npm #398

signalwerk opened this issue Mar 20, 2018 · 5 comments

Comments

@signalwerk
Copy link
Contributor

I found a bug in the package @amazee/react-scripts this repo is using. Unfortunately the github-project (https://github.com/AmazeeLabs/amazee-js) is not longer available. Any suggestions how to file the bug now? Would be great if @Schnitzel or @fubhy could bring it back. 🙊

@fubhy
Copy link
Contributor

fubhy commented Mar 27, 2018

It was never public AFAIK. It's a custom fork we made from CRA. I am going to move this project towards next.js in the next days anyways so it will not be using it for much longer anyways. Stay tuned!

@fubhy fubhy closed this as completed Mar 27, 2018
@fubhy
Copy link
Contributor

fubhy commented Mar 27, 2018

@signalwerk I've started to work on it here: #399

Just a few final tweaks left. Works already.

@signalwerk
Copy link
Contributor Author

😻 wow. massive pr. I'm right now on a productive project with the current setup. I think we try to switch with our codebase as well, since we are not nearly finished now. and with next in place we can configure the webpack like we need it. that sounds good! thx a lot for your work!

@fubhy
Copy link
Contributor

fubhy commented Mar 28, 2018

@signalwerk I've merged the pull request. There are a few things missing I'd like to add later: #400

@signalwerk
Copy link
Contributor Author

@fubhy thanks a lot! looks like there is still a way to go! unfortunately we (the company attribute from zurich & me as a freelancer) are quite new in the game with decoupled-drupal and we are not sure if we are really a help at that stage. But we try whenever possible to bring stuff upstream.
do you think at the current state it makes sense to switch to the next.js setup? or do you think we should role with the old one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants