You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
First, thanks for that. Amazing plugin! I was about to create one when I found it. 😅
My issue looks more like a discussion, but anyway. I saw this comment regarding entry point chunks:
Note that only entry files are checked. vite-plugin-bundlesize won’t measure lazy-loaded code because that is not render blocking. Ideally this helps you focus on only meaningful metrics in regards to bundle sizes.
In the first view, I got the point, after using the plugin I'm not sure if it makes sense. Reasons:
For those who use the split vendor approach: vendor chunk is not an entry point chunk, but that can become bigger, so would be really nice to follow its size;
Load chunks can also become too big (controlling their size would amazing!)
Just to give you more context: I wanna use the size limit to avoid new big chunks being created (on CI). Ideally, I don't care if it is an entry file or not, because I'm thinking about the user experience of downloading big files.
ex:
As it shows, the vendor chunk is passing on the plugin validation. Code:
Suggestion:
Guess the decision to define the type chunk limit is from the client (I mean, who is using the plugin). So, instead of also giving the responsibility to the plugin to validate entry chunks only, it could only validate by name and the client defines the rules by it. I have tested locally by removing this validation and it worked perfect: || !chunk.isEntry
That make sense?
The text was updated successfully, but these errors were encountered:
tassioFront
changed the title
Check other chunks instead of entry fiels only
Check other chunks instead of entry one only
Jul 22, 2024
First, thanks for that. Amazing plugin! I was about to create one when I found it. 😅
My issue looks more like a discussion, but anyway. I saw this comment regarding entry point chunks:
In the first view, I got the point, after using the plugin I'm not sure if it makes sense. Reasons:
Just to give you more context: I wanna use the size limit to avoid new big chunks being created (on CI). Ideally, I don't care if it is an entry file or not, because I'm thinking about the user experience of downloading big files.
ex:
As it shows, the vendor chunk is passing on the plugin validation. Code:
Suggestion:
Guess the decision to define the type chunk limit is from the client (I mean, who is using the plugin). So, instead of also giving the responsibility to the plugin to validate entry chunks only, it could only validate by name and the client defines the rules by it. I have tested locally by removing this validation and it worked perfect:
|| !chunk.isEntry
That make sense?
The text was updated successfully, but these errors were encountered: